Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_connection - validations #19172

Merged
merged 4 commits into from
May 6, 2021
Merged

r/glue_connection - validations #19172

merged 4 commits into from
May 6, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 30, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueConnection_'
--- PASS: TestAccAWSGlueConnection_disappears (32.85s)
--- PASS: TestAccAWSGlueConnection_MongoDB (43.86s)
--- PASS: TestAccAWSGlueConnection_basic (46.61s)
--- PASS: TestAccAWSGlueConnection_Kafka (46.79s)
--- PASS: TestAccAWSGlueConnection_Description (71.50s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (99.65s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (772.30s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner April 30, 2021 08:45
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. labels Apr 30, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 30, 2021
DrFaust92
DrFaust92 commented Apr 30, 2021
View reviewed changes
aws/validators.go
@@ -2446,6 +2446,29 @@ func MapKeysDoNotMatch(r *regexp.Regexp, message string) schema.SchemaValidateFu
}
}

func MapKeyInSlice(valid []string, ignoreCase bool) schema.SchemaValidateFunc {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may want to be moved to upstream sdk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also hashicorp/terraform-plugin-sdk#649.

@ewbankkit ewbankkit self-assigned this May 3, 2021
ewbankkit
ewbankkit approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueConnection_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSGlueConnection_ -timeout 180m
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_MatchCriteria
--- PASS: TestAccAWSGlueConnection_MongoDB (15.64s)
=== CONT  TestAccAWSGlueConnection_disappears
--- PASS: TestAccAWSGlueConnection_disappears (9.46s)
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
--- PASS: TestAccAWSGlueConnection_MatchCriteria (34.93s)
=== CONT  TestAccAWSGlueConnection_basic
--- PASS: TestAccAWSGlueConnection_basic (12.69s)
=== CONT  TestAccAWSGlueConnection_Description
--- PASS: TestAccAWSGlueConnection_Description (21.98s)
=== CONT  TestAccAWSGlueConnection_Kafka
--- PASS: TestAccAWSGlueConnection_Kafka (13.01s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (692.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	717.236s

@ewbankkit ewbankkit removed their assignment May 3, 2021
@ewbankkit ewbankkit merged commit cdcfab0 into hashicorp:main May 6, 2021
@github-actions github-actions bot added this to the v3.39.0 milestone May 6, 2021
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/glue_connection_validations branch May 7, 2021 05:57
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit